@qihqi please review

a kindly ping @qihqi

Just to understand: so the GeneratorImpl doesn't actually implement the RNG algorithm only manages the state?

Just to understand: so the GeneratorImpl doesn't actually implement the RNG algorithm only manages the state?

that is correct. it is exactly what https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/cuda/CUDAGeneratorImpl.h does. the idea is that the generator manages the state and different RNG algorithm generates the random numbers based on the state obtained from the generator.

@qihqi is there anyway to auto-format the cpp code? i know we use yapf for python files in this project.

@qihqi is there anyway to auto-format the cpp code? i know we use yapf for python files in this project.

nvm, i found the linter uses clang-format-16. i will update the contribution instruction for cpp formatting later. a more important question that needs your attention is #9159 (comment). but if you don't have a strong opinion on it, i will do on my discretion.

it seems that the failed tests are not related to this change. i've formatted the files.

I don't have the permission to run the tests, please trigger them for me. also, merge if it LGTY. thanks! @qihqi